Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #67

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Update CODEOWNERS #67

merged 7 commits into from
Apr 11, 2024

Conversation

calebmackdavenport
Copy link
Contributor

No description provided.

@@ -1 +1 @@
* @jkhusanov @ChiefoftheOwls @marquessv
* @jkhusanov @ChiefoftheOwls @marquessv @calebmackdavenport
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove @ChiefoftheOwls @marquessv ?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (419ff23) 89.40% compared to head (7435c7b) 89.40%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           development      #67   +/-   ##
============================================
  Coverage        89.40%   89.40%           
============================================
  Files                5        5           
  Lines              151      151           
  Branches            48       48           
============================================
  Hits               135      135           
  Misses              16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rkyle35242 rkyle35242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need more folks than just you two?

@@ -1 +1 @@
* @jkhusanov @ChiefoftheOwls @marquessv
* @jkhusanov @calebmackdavenport @rkyle35242
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jk, I'm cool to be on here

Copy link
Member

@rkyle35242 rkyle35242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add all the engineers that are Senior and up

@jkhusanov jkhusanov merged commit 30726b4 into development Apr 11, 2024
3 checks passed
@jkhusanov jkhusanov deleted the cmd/update-codeowners branch April 11, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants